We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2592 - [PATCH] Fix warnings in NaCl build
Summary: [PATCH] Fix warnings in NaCl build
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.1
Hardware: x86_64 Other
: P2 normal
Assignee: Gabriel Jacobo
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-18 18:32 UTC by Sam Clegg
Modified: 2014-06-20 14:51 UTC (History)
0 users

See Also:

Attachments
patch file (10.38 KB, patch)
2014-06-18 18:32 UTC, Sam Clegg 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Clegg 2014-06-18 18:32:53 UTC 
Created attachment 1687 [details]
patch file

This is actually two different patches.  One fixes the warnings, the other cleans up the nacl build-scripts.

The patch was generated with 'git log -p' so it contains the CL descriptions.
Comment 1 Gabriel Jacobo 2014-06-20 14:51:43 UTC 
Thanks! This is commited now. I discarded the naclbuild.sh changes because the script fails to build (the include paths gets modified in a way that SDL can't find the configure generated SDL_config.h first in the path). Feel free to re send that (try wiping the build directory clean for testing because sometimes it will appear to work but it's using an old binary to build).

Also, git patches are a pain in the ass for us :) (Or I'm not importing them correctly).