We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2560 - Crash on any input
Summary: Crash on any input
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: events (show other bugs)
Version: HG 1.2
Hardware: x86_64 Mac OS X (All)
: P2 critical
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-24 23:28 UTC by Alex Marshall
Modified: 2014-06-22 18:10 UTC (History)
1 user (show)

See Also:

Attachments
Patch to fix the crashing bug. (662 bytes, patch)
2014-05-24 23:28 UTC, Alex Marshall 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Marshall 2014-05-24 23:28:02 UTC 
Created attachment 1660 [details]
Patch to fix the crashing bug.

On all of my OSX machines running 10.9 (I posted OS as Mac OS X (All) due to there not being a 10.9 selection), I get a crash on any input using SDL 1.2. I've had this issue in both HG 1.2 and final release 1.2 on the website.

Today I got around to trying to fix it; commenting out the two uses of 'field_edit' in src/video/quartz/SQL_QuartzEvents.m fixes the crash and doesn't cause any side effects as far as I can tell.

I've attached the patch, feel free to use it as deemed appropriate.
Comment 1 Sam Lantinga 2014-06-22 18:10:05 UTC 
I didn't do any deep investigation of whether this is the right fix, but not crashing is better than always crashing. Thanks! 
https://hg.libsdl.org/SDL/rev/606600f0f6d7