We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2545 - software renderer texture formats don't seem sorted properly
Summary: software renderer texture formats don't seem sorted properly
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.3
Hardware: x86_64 Windows 7
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-14 01:33 UTC by Adam M.
Modified: 2014-06-22 16:43 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam M. 2014-05-14 01:33:20 UTC 
Sam Lantinga wrote in bug #2401 that "The texture formats listed in SDL_RendererInfo are sorted in order of preference."

But for the software renderer on Windows, anyway, the texture formats are listed in this order: RGB555, RGB565, RGB888, BGR888, ARGB8888, etc. Is RGB555 really the preferred texture format? That seems unlikely.
Comment 1 Sam Lantinga 2014-06-22 04:47:48 UTC 
Good point. I think that the 565 formats were faster at one point because they move less data, but I'm changing it so the renderers are consistent.
https://hg.libsdl.org/SDL/rev/c38e754cafd3

Thanks!
Comment 2 Adam M. 2014-06-22 13:48:13 UTC 
That's understandable, but even if so you'd expect 565 to come before 555, since it's the same number of bytes per pixel but higher quality.
Comment 3 Sam Lantinga 2014-06-22 16:43:52 UTC 
Good point. Fixed!
https://hg.libsdl.org/SDL/rev/e4c67eb79af8