Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Mac: black bar at top of screen in SDL_WINDOW_FULLSCREEN mode #1475

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: Mac OS X (All), x86

Comments on the original bug report:

On 2014-05-10 21:21:58 +0000, Alex Szpakowski wrote:

Created attachment 1643
Patch to fix the y component of the position of fullscreen windows in OS X.

In Mac OS X with the latest Mercurial code, when a window is in exclusive-fullscreen the y component of its position is offset by the same amount that is normally taken up by the menubar, resulting in a black bar at the top of the screen.

The recent changes to the internal ConvertNSRect function make it treat the bottom of the menubar as 0 for the y component of window positions, even when the window is fullscreen and 'above' the menubar.

I have attached a patch which fixes the issue by only making the window position relative to the menubar in windowed modes.

On 2014-05-19 20:27:40 +0000, Eric Wasylishen wrote:

Created attachment 1655
Regenerated patch

I can confirm this problem with latest mercurial and OS X 10.9.2.
To reproduce, run testdraw2 with the command-line arguments "--fullscreen --geometry 1920x1080" (I'm using a 1920x1080 external monitor).

Thanks for the patch Alex, it fixes the problem for me. I had some trouble applying it, so I uploaded my regenerated version - the content of the patch is the same though.

On 2014-05-19 20:29:01 +0000, Alex Szpakowski wrote:

Sorry about that - I forgot to generate it from a clean copy of SDL_cocoawindow.m. :(

On 2014-06-02 16:18:00 +0000, Sam Lantinga wrote:

Fixed, thanks!
http://hg.libsdl.org/SDL/rev/98173814b673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant