We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2508 - don't redefine WIN32_LEAN_AND_MEAN
Summary: don't redefine WIN32_LEAN_AND_MEAN
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.1
Hardware: x86 Windows (All)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-23 20:44 UTC by Anthony Pesch
Modified: 2014-07-01 00:31 UTC (History)
1 user (show)

See Also:

Attachments
WIN32_LEAN_AND_MEAN patch (362 bytes, patch)
2014-04-23 20:44 UTC, Anthony Pesch 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Pesch 2014-04-23 20:44:17 UTC 
Created attachment 1632 [details]
WIN32_LEAN_AND_MEAN patch

Just as with NOMINMAX, WIN32_LEAN_AND_MEAN shouldn't be defined if already defined.

Otherwise, this can issue a warning which is problematic with /WX.
Comment 1 Sam Lantinga 2014-04-26 19:38:58 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/7a261af2d612
Comment 2 Jørgen Tjernø 2014-07-01 00:31:03 UTC 
Also applied this fix to SDL_syswm.h: https://hg.libsdl.org/SDL/rev/47decd0106f8