We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2495 - automake libtool invocation doesn't use set the tag type
Summary: automake libtool invocation doesn't use set the tag type
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: audio (show other bugs)
Version: HG 2.1
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-14 02:21 UTC by Steven Stewart-Gallus
Modified: 2014-04-26 19:46 UTC (History)
0 users

See Also:


Attachments
A simple patch (61.18 KB, patch)
2014-04-19 23:30 UTC, Steven Stewart-Gallus
Details | Diff
This patch doesn't have the checked in autotools build scripts noise (2.88 KB, patch)
2014-04-19 23:35 UTC, Steven Stewart-Gallus
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Stewart-Gallus 2014-04-14 02:21:37 UTC
Invocations of libtool should set the tag type as with the option --tag=cc. This breaks passing through mock compilers for static analysis purposes among other things. Automake would've done this automatically.
Comment 1 Sam Lantinga 2014-04-18 05:01:33 UTC
Can you provide a patch so we know it's set up correctly?

Thanks!
Comment 2 Steven Stewart-Gallus 2014-04-19 23:30:07 UTC
Created attachment 1629 [details]
A simple patch

Okay here's the patch.
Comment 3 Steven Stewart-Gallus 2014-04-19 23:35:13 UTC
Created attachment 1630 [details]
This patch doesn't have the checked in autotools build scripts noise

Sorry, the last patch had some automake version noise.
Comment 4 Sam Lantinga 2014-04-26 19:46:13 UTC
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/4f1fc737b017