This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Fix to 'SDL_OpenAudio', as described in bug description. (patch0, text/plain, 2014-03-27 12:57:18 +0000, 640 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2014-03-27 12:57:18 +0000, Rainer Deyke wrote:

Created attachment 1599
Fix to 'SDL_OpenAudio', as described in bug description.

If 'SDL_OpenAudio' is called with 'obtained == NULL', 'prepare_audiospec' performs a bad 'memcpy' with the destination and source pointing to the same block of memory. The problem appears to be on in 'SDL_OpenAudio', which calls open_audio_device with 'obtained = desired' when 'obtained == NULL'. 'open_audio_device' cannot deal with 'desired' and 'obtained' pointing to the same block of memory but can deal with 'obtained == NULL', so my proposed fix is to simply remove the special handling of 'obtained == NULL' from 'SDL_OpenAudio'.

On 2014-06-24 08:41:30 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/c9be8299ba6b