We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2460 - OUYA Controller mini-touch screen registered as separate device
Summary: OUYA Controller mini-touch screen registered as separate device
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: 2.0.3
Hardware: x86_64 Windows 7
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4, triage-2.0.4
Depends on:
Blocks:
 
Reported: 2014-03-21 05:05 UTC by Justin
Modified: 2015-04-08 06:16 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin 2014-03-21 05:05:34 UTC 
SDL_CONTROLLERDEVICEADDED is being sent twice: once for the controller and once for the touch pad.

this is my patch, in SDL_dxjoystick.c:

static BOOL CALLBACK
    EnumJoysticksCallback(const DIDEVICEINSTANCE * pdidInstance, VOID * pContext)
{
    JoyStick_DeviceData *pNewJoystick;
    JoyStick_DeviceData *pPrevJoystick = NULL;

    int t = pdidInstance->dwDevType & 0xFF;
    if(t != DI8DEVTYPE_JOYSTICK && t != DI8DEVTYPE_GAMEPAD)
    {
        return DIENUM_CONTINUE;
    }
    // the touch pad would be DI8DEVTYPE_SUPPLEMENTAL 
    ...
Comment 1 Ryan C. Gordon 2015-02-19 06:32:13 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry
if you got a lot of email from this. This is to help me sort through some bugs
in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4,
though!
Comment 2 Ryan C. Gordon 2015-04-07 04:57:57 UTC 
(sorry if you get a lot of copies of this email, I'm marking several bugs at once)

Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship.

(Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.)

--ryan.
Comment 3 Ryan C. Gordon 2015-04-08 06:16:18 UTC 
Fixed in https://hg.libsdl.org/SDL/rev/d5adc0c06a03, thanks!

--ryan.