This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Testcase demonstrating the bug and a possible fix (sdl_resample_bug.zip, application/zip, 2014-02-10 16:18:15 +0000, 1610 bytes)
• My proposed fix. (sdlgenaudiocvt.pl.diff, text/plain, 2014-06-04 16:47:22 +0000, 639 bytes)

Reported in version: 2.0.1
Reported for operating system, platform: Windows (XP), x86

Comments on the original bug report:

On 2014-02-10 16:18:15 +0000, Dávid Nagy wrote:

Created attachment 1554
Testcase demonstrating the bug and a possible fix

When resampling, the calculation of the new size ignores the size of the samples (and the number of channels).
const int dstsize = (int) (((double)cvt->len_cvt) * cvt->rate_incr);
This might result in a size that is not a multiple of the sample size.
And since upsampling is done from the end to the beginning, the new samples will start at the wrong place.

On 2014-02-23 01:48:29 +0000, Sam Lantinga wrote:

Ryan, can you look at this for the 2.0.2 release?

Thanks!

On 2014-06-04 16:47:22 +0000, Dávid Nagy wrote:

Created attachment 1669
My proposed fix.

Apply to SDL2-2.0.1/src/audio/sdlgenaudiocvt.pl

On 2014-06-10 23:40:10 +0000, Ryan C. Gordon wrote:

(In reply to nagydavid91+sdl-bugzilla from comment # 2)

Created attachment 1669 [details]
My proposed fix.

This patch is now https://hg.libsdl.org/SDL/rev/5da12bedaace ...thanks!

--ryan.