We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2371 - Addition of SDL_SYSWM_WAYLAND enum value breaks binary compatibility for 2.0.2
Summary: Addition of SDL_SYSWM_WAYLAND enum value breaks binary compatibility for 2.0.2
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 blocker
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-28 11:49 UTC by Gerry JJ
Modified: 2014-01-28 12:24 UTC (History)
0 users

See Also:

Attachments
Move the SDL_SYSWM_WAYLAND value to the end of the enum (388 bytes, patch)
2014-01-28 11:49 UTC, Gerry JJ 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerry JJ 2014-01-28 11:49:53 UTC 
Created attachment 1540 [details]
Move the SDL_SYSWM_WAYLAND value to the end of the enum

Posted about this on the mailing list, but thought I'd better file a bug report too in case you don't see it.

Changeset 4fc5f66d63cc added Wayland support. The SDL_SYSWM_TYPE enum in SDL_syswm.h was modified to add the SDL_SYSWM_WAYLAND value, but it was added to the middle instead of the end, changing the values of SDL_SYSWM_DIRECTFB, SDL_SYSWM_COCOA and SDL_SYSWM_UIKIT. So, any code using those values that was compiled against SDL before this change will use the wrong value when dynamically linked against a newer version of SDL.

I suggest moving the SDL_SYSWM_WAYLAND value to the end of the enum =]
Comment 1 Gerry JJ 2014-01-28 12:24:43 UTC 
Gabriel Jacobo just committed a fix for this, so closing. Sorry for the noise