Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message boxes under X11 are sluggish #1304

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Message boxes under X11 are sluggish #1304

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

SDLBugzilla commented Feb 10, 2021

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.1
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2014-01-10 16:56:30 +0000, Melker Narikka wrote:

Created attachment 1519
patch to reduce unnecessary rendering

Message boxes do a full re-render whenever the mouse moves.
With a long message string, this will result in flickering graphics
and poor responsiveness.

The attached patch works around this issue by avoiding a re-render
unless button focus changes.

It would probably be better to add XDamage and/or Xdbe support.

On 2014-01-23 13:40:02 +0000, Melker Narikka wrote:

Created attachment 1532
patch that adds Xdbe support

The attached patch adds Xdbe support and makes message boxes flicker-free.
It is an extension of the initial patch, i.e. it contains its changes as well.
It should contain the necessary build system changes too.

On 2014-01-23 15:49:20 +0000, Melker Narikka wrote:

Created attachment 1533
patch that adds Xdbe support - v2

This patch adds a more proper runtime check for Xdbe, a call to XdbeQueryExtension. In addition, it also includes the changes made to ./configure by ./autogen.sh.

On 2014-01-27 18:19:51 +0000, Melker Narikka wrote:

Created attachment 1539
patch that adds Xdbe support - v3

The only difference here compared to v2 should be the incorporation of the pretty new autoconf logging introduced in 5226058345bf. This is a one-line change in configure.in.

On 2014-01-27 21:44:36 +0000, (disabled) Jørgen Tjernø wrote:

http://hg.libsdl.org/SDL/rev/06922987b6ff

Will add Xdbe support after 2.0.2 ships.

On 2014-01-28 01:23:40 +0000, Ryan C. Gordon wrote:

Comment on attachment 1539
patch that adds Xdbe support - v3

Checking if the mouseover index changed is now https://hg.libsdl.org/SDL/rev/06922987b6ff ...

We'll leave this open until the rest of the patch is dealt with, though!

--ryan.

On 2014-01-28 01:24:18 +0000, Ryan C. Gordon wrote:

(In reply to Jørgen Tjernø from comment # 4)

http://hg.libsdl.org/SDL/rev/06922987b6ff

Will add Xdbe support after 2.0.2 ships.

Oh, yeah, what he said. :)

--ryan.

On 2014-09-23 09:25:40 +0000, Melker Narikka wrote:

Any word on this? The patch still seems to apply. :)

On 2015-02-19 05:22:18 +0000, Ryan C. Gordon wrote:

Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!

On 2015-04-07 04:57:55 +0000, Ryan C. Gordon wrote:

(sorry if you get a lot of copies of this email, I'm marking several bugs at once)

Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship.

(Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.)

--ryan.

On 2015-05-28 04:31:36 +0000, Ryan C. Gordon wrote:

The Xdbe support is now in revision control as https://hg.libsdl.org/SDL/rev/fbc01731d914, thanks!

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant