We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2343 - Message boxes under X11 are sluggish
Summary: Message boxes under X11 are sluggish
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.1
Hardware: x86_64 Linux
: P2 normal
Assignee: (disabled) Jørgen Tjernø
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4, triage-2.0.4
Depends on:
Blocks:
 
Reported: 2014-01-10 16:56 UTC by Melker Narikka
Modified: 2015-05-28 04:31 UTC (History)
2 users (show)

See Also:

Attachments
patch to reduce unnecessary rendering (623 bytes, patch)
2014-01-10 16:56 UTC, Melker Narikka 		Details | Diff
patch that adds Xdbe support (10.82 KB, patch)
2014-01-23 13:40 UTC, Melker Narikka 		Details | Diff
patch that adds Xdbe support - v2 (12.76 KB, patch)
2014-01-23 15:49 UTC, Melker Narikka 		Details | Diff
patch that adds Xdbe support - v3 (12.88 KB, patch)
2014-01-27 18:19 UTC, Melker Narikka 		Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Melker Narikka 2014-01-10 16:56:30 UTC 
Created attachment 1519 [details]
patch to reduce unnecessary rendering

Message boxes do a full re-render whenever the mouse moves.
With a long message string, this will result in flickering graphics
and poor responsiveness.

The attached patch works around this issue by avoiding a re-render
unless button focus changes.

It would probably be better to add XDamage and/or Xdbe support.
Comment 1 Melker Narikka 2014-01-23 13:40:02 UTC 
Created attachment 1532 [details]
patch that adds Xdbe support

The attached patch adds Xdbe support and makes message boxes flicker-free.
It is an extension of the initial patch, i.e. it contains its changes as well.
It should contain the necessary build system changes too.
Comment 2 Melker Narikka 2014-01-23 15:49:20 UTC 
Created attachment 1533 [details]
patch that adds Xdbe support - v2

This patch adds a more proper runtime check for Xdbe, a call to XdbeQueryExtension. In addition, it also includes the changes made to ./configure by ./autogen.sh.
Comment 3 Melker Narikka 2014-01-27 18:19:51 UTC 
Created attachment 1539 [details]
patch that adds Xdbe support - v3

The only difference here compared to v2 should be the incorporation of the pretty new autoconf logging introduced in 5226058345bf. This is a one-line change in configure.in.
Comment 4 (disabled) Jørgen Tjernø 2014-01-27 21:44:36 UTC 
http://hg.libsdl.org/SDL/rev/06922987b6ff

Will add Xdbe support after 2.0.2 ships.
Comment 5 Ryan C. Gordon 2014-01-28 01:23:40 UTC 
Comment on attachment 1539 [details]
patch that adds Xdbe support - v3


Checking if the mouseover index changed is now https://hg.libsdl.org/SDL/rev/06922987b6ff ...

We'll leave this open until the rest of the patch is dealt with, though!

--ryan.
Comment 6 Ryan C. Gordon 2014-01-28 01:24:18 UTC 
(In reply to Jørgen Tjernø from comment #4)
> http://hg.libsdl.org/SDL/rev/06922987b6ff
> 
> Will add Xdbe support after 2.0.2 ships.

Oh, yeah, what he said.  :)

--ryan.
Comment 7 Melker Narikka 2014-09-23 09:25:40 UTC 
Any word on this? The patch still seems to apply. :)
Comment 8 Ryan C. Gordon 2015-02-19 05:22:18 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 9 Ryan C. Gordon 2015-04-07 04:57:55 UTC 
(sorry if you get a lot of copies of this email, I'm marking several bugs at once)

Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship.

(Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.)

--ryan.
Comment 10 Ryan C. Gordon 2015-05-28 04:31:36 UTC 
The Xdbe support is now in revision control as https://hg.libsdl.org/SDL/rev/fbc01731d914, thanks!

--ryan.