We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 233 - Inconsistent use of SDLCALL causes syntax errors under Watcom
Summary: Inconsistent use of SDLCALL causes syntax errors under Watcom
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: audio (show other bugs)
Version: 1.2.9
Hardware: x86 Windows (XP)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-18 12:26 UTC by Terry Colligan
Modified: 2006-05-24 12:34 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Colligan 2006-05-18 12:26:57 UTC 
Many, if not all, of the structure members of SDL which store function pointers are declared with the SDLCALL macro attribute.  Unfortunately, most, if not all,
of the functions whose addresses are stored in those pointers are NOT declared with the SDLCALL macro attribute.  This leads to syntax errors under Watcom when maximum error checking is enabled.

This occurs most often in SDL_audiocvt.c, but in a number of other modules as well.

I can submit patches if desired.
Comment 1 Dmitry Yakimov 2006-05-19 04:05:09 UTC 
I can remember that a compiler for x86 wince emulation as well did not like that and did not compile.
Comment 2 Terry Colligan 2006-05-24 12:34:44 UTC 
This problem appears to be fixed in the current subversion repository.  I checked out everything, and ran my Watcom compiles again, and didn't get the syntax errors I was previous getting involving inconsistent use of SDLCALL.