We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2224 - Check if keycode_to_SDL returns a nonnegative value (before calling SDL_PrivateJoystickButton).
Summary: Check if keycode_to_SDL returns a nonnegative value (before calling SDL_Priva...
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.1
Hardware: All Android (All)
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-11 10:54 UTC by ny00
Modified: 2013-11-11 13:16 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ny00 2013-11-11 10:54:59 UTC 
With a recent commit fixing Bug 2214, keycode_to_SDL may return the (int) value of -1, to be passed to SDL_PrivateJoystickButton as is. (See Android_OnPadDown and Android_OnPadUp in src/joystick/android/SDL_sysjoystick.c.)
Comment 1 Gabriel Jacobo 2013-11-11 13:16:50 UTC 
Fixed: https://hg.libsdl.org/SDL/rev/965b7e09c5a8