Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window loses maximized state when activated #1138

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Window loses maximized state when activated #1138

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.0
Reported for operating system, platform: Windows (All), All

Comments on the original bug report:

On 2013-10-22 13:54:01 +0000, wrote:

Changeset 357bccc72a1c [1] introduced a new issue that yanks a window out of its maximized state when activated. For example switching to another window with the taskbar and back to the SDL window. The call stack looks like this.

WIN_RaiseWindow [src\video\windows\sdl_windowswindow.c @ 406]
SDL_RaiseWindow [src\video\sdl_video.c @ 1769]
SDL_OnWindowRestored [src\video\sdl_video.c @ 2079]
SDL_SendWindowEvent [src\events\sdl_windowevents.c @ 144]

WIN_RaiseWindow now calls WIN_RestoreWindow which has the effect of removing the maximized state.

I have to activate it twice sometimes to get this effect. Don't know why.

1: http://hg.libsdl.org/SDL/rev/357bccc72a1c

On 2013-10-22 13:56:11 +0000, wrote:

I forgot the WindowProc call in the call stack before SDL_SendWindowEvent.

WIN_WindowProc [src\video\windows\sdl_windowsevents.c @ 349]

On 2013-11-08 22:13:14 +0000, Sam Lantinga wrote:

Fixed, thanks!
http://hg.libsdl.org/SDL/rev/94ed2e31a603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant