We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2168 - [Patch] Mac: SDL_filesystem.h not exported to public header folder when building framework
Summary: [Patch] Mac: SDL_filesystem.h not exported to public header folder when build...
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.0
Hardware: x86 Mac OS X 10.8
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 05:36 UTC by Alex Szpakowski
Modified: 2013-10-21 09:46 UTC (History)
0 users

See Also:

Attachments
Patch to add SDL_filesystem.h to the framework's public header folder. (995 bytes, patch)
2013-10-21 05:36 UTC, Alex Szpakowski 		Details | Diff
Fixed patch (1.50 KB, patch)
2013-10-21 09:42 UTC, Alex Szpakowski 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Szpakowski 2013-10-21 05:36:54 UTC 
Created attachment 1384 [details]
Patch to add SDL_filesystem.h to the framework's public header folder.

When compiling SDL as a framework using the Xcode project, SDL_filesystem.h isn't put in the framework's Headers folder with the rest of the public header files.

This results in compile errors in code which includes SDL.h, since SDL.h tries to include the missing SDL_filesystem.h.

I've attached a patch which fixes the issue.
Comment 1 Sam Lantinga 2013-10-21 09:21:04 UTC 
Fixed, thanks!
http://hg.libsdl.org/SDL/rev/ff9f1a1ed2dd
Comment 2 Alex Szpakowski 2013-10-21 09:42:09 UTC 
Created attachment 1386 [details]
Fixed patch

I actually made a mistake when creating the previous patch file... I forgot to include a crucial line which changed.

I've attached a new patch which just changes the line I forgot, since the other part has already been applied to the repository.
I tested this one by doing a clean rebuild of SDL, and it works with the new patch.

Sorry about that!
Comment 3 Sam Lantinga 2013-10-21 09:46:36 UTC 
Applied, thanks!
http://hg.libsdl.org/SDL/rev/4bb403bb0c06