We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

There's a bug in SDL_RegisterApp and SDL_UnregisterApp in file SDL_windowsevents.c. In there some reference counting is going on to ensure the Win32 windowclass (or application class as you will) only gets registered once upon first class registration and only gets unregistered once upon last class unregistration. As there is no bounds checking being performed, the reference counter can overflow/underflow. If this happens you'll have a memory leak, because SDL_Appname will then not be freed in SDL_UnregisterApp.

In SDL_RegisterApp:
/* Only do this once... */
    if (app_registered) {
        ++app_registered;
        return (0);
    }

I'm aware that in normal situations this function shouldn't be called this often, but if it's called beyond INT_MAX times, then the reference counter will go below zero. Not only will this make unregistration of the window class/application class impossible in SDL_UnregisterApp, this will also lead to a memory leak since SDL_AppName will not be freed. While I'd consider a memory leak serious undesired, the failure of not unregistring the window class/application class is less problematic as the Win32 API will do this for you automatically on program shutdown.

To fix this I suggest to do some bounds checking in both functions. Like so:
    if (app_registered) {
        if (INT_MAX > app_registered)
        {
          ++app_registered;
        }
        else
        {
          /* FAIL, Set error or something. It's a void function not being able to return success state */
          return;
        }
        return (0);
    }