You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changing back to old code fixes EDuke32 music, obviously it is hitting the >= MAXCHAN test, don't know enough about timidity to know why this was added or if it is needed.
What is meep->event.channel in this case? That test was added to prevent memory corruption in timidity code.
Maybe we can just increase MAXCHAN?
On 2013-11-03 20:33:21 +0000, wrote:
Testing from a less-than-two-weeks old build of SDL_mixer 2.0.0, playmus included (which seems to be ok since there has been just one Android-specific commit today):
After starting playmus with castles.mid, gdb catches this event first (meep->event):
{time = 0, channel = 255 '\377', type = 0 '\000', a = 0 '\000',
b = 0 '\000'}
Afterwards, there even is caught:
{time = 0, channel = 45 '-', type = 10 '\n', a = 10 '\n', b = 230 '\346'}
Finally, the MIDI is played back faster than intended.
Having practically no real knowledge of MIDI..
It seems like the test against MAXCHAN can safely be relocated after the check if (meep->event.type==ME_TEMPO), with no risk of memory corruption, at least in this function.
On 2013-11-03 21:35:18 +0000, Sam Lantinga wrote:
You're right, it looks like that field is reused for another purpose for the tempo event.
This bug report was migrated from our old Bugzilla tracker.
Reported in version: unspecified
Reported for operating system, platform: Linux, x86_64
Comments on the original bug report:
On 2013-10-08 09:45:41 +0000, wrote:
On 2013-10-08 09:58:51 +0000, wrote:
On 2013-10-29 21:46:27 +0000, Emile Belanger wrote:
On 2013-10-29 21:49:52 +0000, wrote:
On 2013-11-03 19:24:53 +0000, Sam Lantinga wrote:
On 2013-11-03 20:33:21 +0000, wrote:
On 2013-11-03 21:35:18 +0000, Sam Lantinga wrote:
On 2013-11-03 21:58:57 +0000, wrote:
On 2013-11-04 06:25:19 +0000, Ryan C. Gordon wrote:
On 2013-11-04 07:32:05 +0000, wrote:
On 2013-11-04 15:18:06 +0000, Ryan C. Gordon wrote:
On 2013-11-04 17:38:31 +0000, wrote:
The text was updated successfully, but these errors were encountered: