We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2130 - Two members of Windows WindowData not initialized
Summary: Two members of Windows WindowData not initialized
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.0
Hardware: All Windows (All)
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-02 18:43 UTC by norfanin
Modified: 2013-10-03 07:55 UTC (History)
0 users

See Also:

Attachments
Initialize all SDL_WindowData members. (456 bytes, patch)
2013-10-02 18:43 UTC, norfanin 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description norfanin 2013-10-02 18:43:31 UTC 
Created attachment 1353 [details]
Initialize all SDL_WindowData members.

SetupWindowData in SDL_windowswindow.c doesn't initialize two members of SDL_WindowData with NULL. This is an issue because other parts of the SDL code seem to make the assumption that this is the case. WIN_DestroyWindowFramebuffer for example uses data->mdc and data->hbm if they're not NULL.
Comment 1 Sam Lantinga 2013-10-03 07:55:25 UTC 
Good catch, thanks!
http://hg.libsdl.org/SDL/rev/dad9001a9fc7