We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2120 - SDL2_image exports miniz symbols
Summary: SDL2_image exports miniz symbols
Status: RESOLVED FIXED
Alias: None
Product: SDL_image
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86_64 Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-29 00:43 UTC by Robert Norris
Modified: 2013-10-01 05:41 UTC (History)
0 users

See Also:

Attachments
make miniz functions static (26.75 KB, patch)
2013-10-01 05:21 UTC, Robert Norris 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Norris 2013-09-29 00:43:00 UTC 
If a project that uses SDL2_image also uses miniz directly, and we're doing a full static build, then final link will fail due to symbol conflicts between the application and the library.

(Pioneer's SDL2 port does this when building with MXE, the MinGW toolchain).

This is best addressed by making functions within miniz itself static. I've submitted a patch for this to miniz:

  https://code.google.com/p/miniz/issues/detail?id=18

In my application I've enabled this so as to make it link, but really its a workaround - the right place for this fix is in SDL2_image itself.
Comment 1 Sam Lantinga 2013-10-01 05:04:10 UTC 
Can you submit a patch that applies cleanly to the version of miniz used by SDL_image (miniz_v114_r1.7z)

Thanks!
Comment 2 Robert Norris 2013-10-01 05:21:50 UTC 
Created attachment 1348 [details]
make miniz functions static
Comment 3 Sam Lantinga 2013-10-01 05:41:33 UTC 
Great patch, thanks!
http://hg.libsdl.org/SDL_image/rev/f4572b5b73f3