Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2_image exports miniz symbols #74

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

SDL2_image exports miniz symbols #74

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: unspecified
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2013-09-29 00:43:00 +0000, Robert Norris wrote:

If a project that uses SDL2_image also uses miniz directly, and we're doing a full static build, then final link will fail due to symbol conflicts between the application and the library.

(Pioneer's SDL2 port does this when building with MXE, the MinGW toolchain).

This is best addressed by making functions within miniz itself static. I've submitted a patch for this to miniz:

https://code.google.com/p/miniz/issues/detail?id=18

In my application I've enabled this so as to make it link, but really its a workaround - the right place for this fix is in SDL2_image itself.

On 2013-10-01 05:04:10 +0000, Sam Lantinga wrote:

Can you submit a patch that applies cleanly to the version of miniz used by SDL_image (miniz_v114_r1.7z)

Thanks!

On 2013-10-01 05:21:50 +0000, Robert Norris wrote:

Created attachment 1348
make miniz functions static

On 2013-10-01 05:41:33 +0000, Sam Lantinga wrote:

Great patch, thanks!
http://hg.libsdl.org/SDL_image/rev/f4572b5b73f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant