We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2055 - FUSIONSOUND_SHARED option in CMakeLists.txt Broken
Summary: FUSIONSOUND_SHARED option in CMakeLists.txt Broken
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: x86_64 Windows 8
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4, triage-2.0.4
Depends on:
Blocks:
 
Reported: 2013-08-22 19:34 UTC by Kaleb Elwert
Modified: 2015-04-08 01:56 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaleb Elwert 2013-08-22 19:34:00 UTC 
http://hg.libsdl.org/SDL/file/76d7b6007a64/CMakeLists.txt#l197

To tell you the truth, I haven't been able to check this, but it looks like the FUSIONSOUND_SHARED option in CMake is broken, as it is a dep_option that depends on itself in stead of simply FUSIONSOUND. Normally I wouldn't file a bug if I wasn't sure, but the other dep_options work differently from this one.

dep_option(FUSIONSOUND_SHARED  "Dynamically load fusionsound audio support" ON "FUSIONSOUND_SHARED" OFF)

vs

dep_option(DIRECTFB_SHARED     "Dynamically load directfb support" ON "VIDEO_DIRECTFB" OFF)
dep_option(ARTS_SHARED         "Dynamically load aRts audio support" ON "ARTS" OFF)

Probably not that big of a deal, but should still be fixed.
Comment 1 Kaleb Elwert 2013-08-22 19:38:20 UTC 
This should, in theory, be as simple as replacing the dep_option line with this:

dep_option(FUSIONSOUND_SHARED  "Dynamically load fusionsound audio support" ON "FUSIONSOUND" OFF)
Comment 2 Ryan C. Gordon 2015-02-19 05:22:20 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 3 Ryan C. Gordon 2015-04-07 04:57:55 UTC 
(sorry if you get a lot of copies of this email, I'm marking several bugs at once)

Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship.

(Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.)

--ryan.
Comment 4 Ryan C. Gordon 2015-04-08 01:56:16 UTC 
This is fixed in https://hg.libsdl.org/SDL/rev/510c9a2f0951, thanks!

--ryan.