We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2048 - C89 Compliance
Summary: C89 Compliance
Status: RESOLVED WONTFIX
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-20 23:41 UTC by Gabriel Jacobo
Modified: 2013-08-21 13:41 UTC (History)
0 users

See Also:

Attachments
C89 compliance log (15.14 KB, text/x-log)
2013-08-20 23:41 UTC, Gabriel Jacobo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Jacobo 2013-08-20 23:41:15 UTC 
Created attachment 1300 [details]
C89 compliance log

LANG="en_US" CC="/usr/bin/gcc -std=c89" make -j4 -i | grep error:

See attached log.

The SDL_quit.c error is fixed by adding #include <bits/sigaction.h> on my system. I don't know if we have to detect that on the configure script or if HAVE_SIGNAL_H is sufficient to include it.
Comment 1 Gabriel Jacobo 2013-08-21 13:41:16 UTC 
Turns out we use inline which is not in the C89 spec (among other things), so we'll make do with "compatible with Visual C and GCC 3+"