We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2046 - [patch] Haiku build broken
Summary: [patch] Haiku build broken
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: 2.0.0
Hardware: All Haiku
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-19 02:15 UTC by Alexander von Gluck IV
Modified: 2013-09-07 06:48 UTC (History)
0 users

See Also:

Attachments
proposed patch v1 (1.13 KB, patch)
2013-08-19 02:18 UTC, Alexander von Gluck IV 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander von Gluck IV 2013-08-19 02:15:59 UTC 
The haiku build is broken due to a missing std namespace id.
There are also quite a bit of dllexport spam when building on Haiku gcc4.

Patch is on its way.
Comment 1 Alexander von Gluck IV 2013-08-19 02:18:36 UTC 
Created attachment 1295 [details]
proposed patch v1

SDL2 compiles and generates static libraries on Haiku gcc2 and gcc4 with these changes.
Comment 2 Sam Lantinga 2013-08-19 05:03:33 UTC 
The default build for SDL is a shared library.  Does the DECLSPEC change break shared library building on gcc 4?
Comment 3 Sam Lantinga 2013-08-19 05:11:38 UTC 
The std:: fix is in, thanks!
http://hg.libsdl.org/SDL/rev/60ef3ee24bca
Comment 4 Alexander von Gluck IV 2013-08-19 06:06:11 UTC 
The DECLSPEC change is mostly a cosmetic fix.  There are thousands of attribute ignored warnings without the change.

I know the shared library building works completely (without warnings) with the attached patch on gcc2 and gcc4 Haiku.  Let me test without and see if it makes a difference in the resulting libraries.

The last else case is to catch non-gcc compilers on BeOS (i assume) the use case for it is pretty dry though.
Comment 5 Sam Lantinga 2013-08-19 06:19:09 UTC 
Okay, looking closer this is a good change.  Can you check my variation on your patch?
http://hg.libsdl.org/SDL/rev/7a8955fe2f63

Thanks!
Comment 6 Alexander von Gluck IV 2013-08-19 06:37:38 UTC 
looks fine to me :)

Thanks!
Comment 7 Sam Lantinga 2013-09-07 06:48:44 UTC 
Great, thanks!