We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1901 - SDL_Log() unconditionally appends newline
Summary: SDL_Log() unconditionally appends newline
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: x86 Windows 7
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-07 12:45 UTC by Sam Lantinga
Modified: 2013-07-06 00:38 UTC (History)
1 user (show)

See Also:

Attachments
Patch to strip newlines from SDL_Log*() calls. (1.77 KB, patch)
2013-07-05 00:43 UTC, Ryan C. Gordon 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Lantinga 2013-06-07 12:45:05 UTC 
If the message coming into SDL_Log() already has a newline, it shouldn't add another one.
Comment 1 Ryan C. Gordon 2013-07-05 00:43:37 UTC 
Created attachment 1207 [details]
Patch to strip newlines from SDL_Log*() calls.


Here's a patch for it, but is it safe to change this, or will apps already be expecting this to pass a newline?

--ryan.
Comment 2 Ryan C. Gordon 2013-07-05 00:44:28 UTC 
Tossing to Sam. "hg import" the patch if you like it.

--ryan.
Comment 3 Ryan C. Gordon 2013-07-05 01:07:53 UTC 
Crap, apparently I pushed this patch already...so feel free to "hg backout" if you like.  :)

--ryan.
Comment 4 Sam Lantinga 2013-07-06 00:38:07 UTC 
Patch looks good, thanks!