We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 189 - SDL_DisplayYUVOverlay() doesn't clip to the screen area
Summary: SDL_DisplayYUVOverlay() doesn't clip to the screen area
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: don't know
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-31 01:11 UTC by Sam Lantinga
Modified: 2006-04-17 02:46 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Lantinga 2006-03-31 01:11:37 UTC 
Date: Wed, 29 Mar 2006 12:38:27 -0500
From: "Shane M. Walton" <swalton75@cox.net>
Subject: Re: [SDL] SDL_DisplayYUVOverlay() segmentation fault

I wanted to add some information and rephrase my question.

The testoverlay.c and testoverlay2.c fail when the SDL_Rect.x/y != 0.
The following occurs:

Created 64x88X3 software YV12 overlay
  ...
X Error failed request:  BadValue (integer parameter out of range for
operation)
  Major opcode of failed request:  145 (MIT-SHM)
  Minor opcode of failed request:  3 (X_ShmPutImage)
  Value in failed request:  0x1b8
  Serial number of failed request:  40
  Current serial number in output stream:  41
Comment 1 Sam Lantinga 2006-04-17 01:40:18 UTC 
This is fixed in CVS.
Comment 2 Sam Lantinga 2006-04-17 01:56:37 UTC 
Actually, this is active for all overlay drivers.
Comment 3 Sam Lantinga 2006-04-17 02:46:47 UTC 
The clipping is done at a higher level, and the low level functions are
passed clipped rectangles.  Drivers which don't support source clipping
have not been changed, so the image will be squished instead of clipped,
but at least they will no longer crash when the destination rect was out
of bounds.