We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1887 - libmad support broken
Summary: libmad support broken
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: P2 major
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-03 06:55 UTC by Marcus von Appen
Modified: 2013-06-03 22:56 UTC (History)
0 users

See Also:

Attachments
music_mad.c patch (696 bytes, patch)
2013-06-03 06:55 UTC, Marcus von Appen 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus von Appen 2013-06-03 06:55:16 UTC 
Created attachment 1169 [details]
music_mad.c patch

MP3 support via libmad is currently broken, since the mad_data struct does not contain fields that are used in music_mad.c:

[...]
../music_mad.c: In function 'mad_openFileRW':
../music_mad.c:35: error: 'mad_data' has no member named 'src'
../music_mad.c:36: error: 'mad_data' has no member named 'freesrc'
../music_mad.c: In function 'mad_closeFile':
../music_mad.c:58: error: 'mad_data' has no member named 'freesrc'
../music_mad.c:59: error: 'mad_data' has no member named 'src'
../music_mad.c:59: error: 'mad_data' has no member named 'src'
gmake: *** [build/music_mad.lo] Error 1

A patch is attached.
Comment 1 Sam Lantinga 2013-06-03 22:56:29 UTC 
Fixed!
http://hg.libsdl.org/SDL_mixer/rev/39fbc5a85070
http://hg.libsdl.org/SDL_mixer/rev/a0d34c8077a1

Please let me know if that doesn't work.