We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1850 - PND_setwindowgrab() is probably wrong
Summary: PND_setwindowgrab() is probably wrong
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: x86_64 Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.0
Depends on:
Blocks:
 
Reported: 2013-05-13 16:19 UTC by Ryan C. Gordon
Modified: 2013-07-15 20:31 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan C. Gordon 2013-05-13 16:19:44 UTC 
The Pandora window grab code looks like this...

void
PND_setwindowgrab(_THIS, SDL_Window * window)
{
    SDL_VideoData *phdata = (SDL_VideoData *) _this->driverdata;
    eglTerminate(phdata->egl_display);
}

Which is a cut-and-paste of PND_destroywindow().  (and is possibly wrong there, too, fwiw.)

The Pandora code should probably become the "egl" target, btw, since the EGL API it uses is also applicable to the Raspberry Pi, etc.

--ryan.
Comment 1 Ryan C. Gordon 2013-07-12 22:15:37 UTC 
(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.0, Priority 2.

This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.
Comment 2 Ryan C. Gordon 2013-07-15 20:31:07 UTC 
Fixed in http://hg.libsdl.org/SDL/rev/e92571f09ce9

--ryan.