We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1808 - SDL_render.c access to already freed pointer (patch attached)
Summary: SDL_render.c access to already freed pointer (patch attached)
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: Other Other
: P1 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.0
Depends on:
Blocks:
 
Reported: 2013-04-17 06:30 UTC by Martin Gerhardy
Modified: 2013-07-13 06:17 UTC (History)
1 user (show)

See Also:

Attachments
fixed freed pointer access (821 bytes, patch)
2013-04-17 06:31 UTC, Martin Gerhardy 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Gerhardy 2013-04-17 06:30:43 UTC 
PSP_DestroyTexture accesses an already freed pointer
Comment 1 Martin Gerhardy 2013-04-17 06:31:12 UTC 
Created attachment 1112 [details]
fixed freed pointer access
Comment 2 Gabriel Jacobo 2013-04-23 15:57:11 UTC 
I applied this patch instead: http://hg.libsdl.org/SDL/rev/640f553441e4

The SDL_Texture pointer shouldn't be released as it is released in SDL_DestroyTexture, and the driverdata was not released.

I don't have a way to test this, can you verify?
Comment 3 Gabriel Jacobo 2013-05-18 19:18:50 UTC 
Did you get a chance to verify this?
Comment 4 Ryan C. Gordon 2013-07-12 18:52:34 UTC 
(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.0, Priority 1.

This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.
Comment 5 Martin Gerhardy 2013-07-13 03:21:55 UTC 
I think this one can be closed as Gabriels patch looks fine.
Comment 6 Sam Lantinga 2013-07-13 06:17:08 UTC 
Thanks!