We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1773 - SDL_BeApp not compiled for Haiku
Summary: SDL_BeApp not compiled for Haiku
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: Other Haiku
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-29 10:55 UTC by Axel Dörfler
Modified: 2013-07-05 01:10 UTC (History)
0 users

See Also:

Attachments
Include SDL_BeApp in Haiku build (352 bytes, patch)
2013-03-29 10:55 UTC, Axel Dörfler 		Details | Diff
__HAIKU__ vs. __BEOS__ patch (1.01 KB, application/octet-stream)
2013-04-22 15:01 UTC, Axel Dörfler 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Axel Dörfler 2013-03-29 10:55:34 UTC 
Created attachment 1082 [details]
Include SDL_BeApp in Haiku build

Haiku does not define __BEOS__ anymore, only __HAIKU__. This fixes linking SDL applications under Haiku.
Comment 1 Ryan C. Gordon 2013-03-29 21:27:01 UTC 
This is now hg changeset c18daa241a02, thanks!

Should we make this change to the __BEOS__ check in src/events/SDL_sysevents.h, too?

--ryan.
Comment 2 Axel Dörfler 2013-03-30 08:26:57 UTC 
Yes, indeed, that should be done, too.

Should the BeOS specific things be removed? While Haiku is backwards compatible, it doesn't mean that the code now will still run on BeOS, although it probably does not hurt to keep it.
Comment 3 Axel Dörfler 2013-04-22 15:01:21 UTC 
Created attachment 1122 [details]
__HAIKU__ vs. __BEOS__ patch

The attached patch solves another case of a missing __HAIKU__ in src/events/SDL_sysevents.h, and also fixes a comment in src/SDL.c.
Comment 4 Ryan C. Gordon 2013-07-05 01:10:06 UTC 
Fixed in hg changeset ff228f955a48, thanks!

--ryan.