Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in buffer size setting in Haiku/BeOS audio driver #716

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Error in buffer size setting in Haiku/BeOS audio driver #716

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 1.2
Reported for operating system, platform: Haiku, x86

Comments on the original bug report:

On 2013-01-01 13:45:27 +0000, PulkoMandy wrote:

Just like in SDL, audio buffer sizes for BeOS and Haiku BSoundPlayer are sized in bytes, not frames. SDL was feeding the wrong value, leading to buffers smaller than expected and weird behaviour in some unsuspecting programs (noticed it in HivelyTracker but others are likely affected as well. The fix is fortunately very simple:

--- a/src/audio/baudio/SDL_beaudio.cc dim. nov. 04 19:07:49 2012 +0100
+++ b/src/audio/baudio/SDL_beaudio.cc mar. janv. 01 22:41:22 2013 +0100
@@ -199,11 +199,11 @@
return (-1);
}

  • format.buffer_size = spec->samples;
  •   /* Calculate the final parameters for this audio specification */
      SDL_CalculateAudioSpec(spec);
    
  • format.buffer_size = spec->size;
  •   /* Subscribe to the audio stream (creates a new thread) */
      { sigset_t omask;
              SDL_MaskSignals(&omask);
    

On 2013-02-11 20:57:20 +0000, Sam Lantinga wrote:

Fixed, thanks!
http://hg.libsdl.org/SDL/rev/245a50142ffb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant