We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1647 - SDL_messagebox.h comma at end of enumerator list
Summary: SDL_messagebox.h comma at end of enumerator list
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 05:15 UTC by Martin Gerhardy
Modified: 2019-09-22 19:01 UTC (History)
2 users (show)

See Also:

Attachments
A fix for this warning made on top of 984e3c6e720f (985 bytes, patch)
2019-09-22 18:37 UTC, Vitaly Novichkov 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Gerhardy 2012-11-20 05:15:10 UTC 
you can't compile your code with -pedantic if you include SDL.h without flooding the console with:

/usr/include/SDL2/SDL_messagebox.h:43:45: warning: comma at end of enumerator list [-pedantic]
Comment 1 Martin Gerhardy 2012-11-20 05:16:31 UTC 
the same for line 52
Comment 2 Ryan C. Gordon 2012-11-21 20:00:45 UTC 
Fixed in hg changeset 9f0d4046f3d6, thanks!

--ryan.
Comment 3 Vitaly Novichkov 2019-09-22 18:27:42 UTC 
It's here back! It's now in the present!

https://hg.libsdl.org/SDL/file/984e3c6e720f/include/SDL_messagebox.h#l43
Comment 4 Vitaly Novichkov 2019-09-22 18:31:23 UTC 
It came back with commit "2b00c2a7cec4":

https://hg.libsdl.org/SDL/rev/2b00c2a7cec4
https://hg.libsdl.org/SDL/diff/2b00c2a7cec4/include/SDL_messagebox.h
Comment 5 Vitaly Novichkov 2019-09-22 18:37:42 UTC 
Created attachment 3972 [details]
A fix for this warning made on top of 984e3c6e720f
Comment 6 Ozkan Sezer 2019-09-22 18:42:23 UTC 
(In reply to Vitaly Novichkov from comment #4)
> It came back with commit "2b00c2a7cec4":
> 
> https://hg.libsdl.org/SDL/rev/2b00c2a7cec4
> https://hg.libsdl.org/SDL/diff/2b00c2a7cec4/include/SDL_messagebox.h

fixed now by https://hg.libsdl.org/SDL/rev/53ae8dc25c6e
Comment 7 Vitaly Novichkov 2019-09-22 19:01:04 UTC 
Thanks, Ozkan!
I'm glad you always coming to help!