We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1609 - XSizeHints shouldn't be statically allocated
Summary: XSizeHints shouldn't be statically allocated
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: All Linux
: P2 minor
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-25 16:20 UTC by Edward Rudd
Modified: 2012-09-26 11:11 UTC (History)
1 user (show)

See Also:

Attachments
patch to allocate Hint structures per Xlib docs. (3.11 KB, patch)
2012-09-25 19:11 UTC, Edward Rudd 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Edward Rudd 2012-09-25 16:20:02 UTC 
According to the X documentation the XSizeHints structure should not be statically allocated (as it is in X11_CreateWindow), but rather dynamically allocated using the XAllocSizeHints() method.

http://www.x.org/releases/X11R7.6/doc/libX11/specs/libX11/libX11.html#Setting_and_Reading_the_WM_NORMAL_HINTS_Property
Comment 1 Edward Rudd 2012-09-25 19:11:03 UTC 
Created attachment 957 [details]
patch to allocate Hint structures per Xlib docs.
Comment 2 Ryan C. Gordon 2012-09-26 11:11:29 UTC 
This patch is now hg changeset 5e09ac1aba80, thanks!

--ryan.