We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1604 - Ogg support detection in static mode [patch]
Summary: Ogg support detection in static mode [patch]
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86_64 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 16:01 UTC by Gabriel Jacobo
Modified: 2012-10-22 12:49 UTC (History)
0 users

See Also:

Attachments
Ogg detection in static mode (2.94 KB, patch)
2012-09-20 16:03 UTC, Gabriel Jacobo 		Details | Diff
Call Music Finish Hook from Mix_HaltMusic (602 bytes, patch)
2012-09-21 13:39 UTC, Gabriel Jacobo 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Jacobo 2012-09-20 16:01:32 UTC 
When --disable-music-ogg-shared the OGG tests fail when they should pass. Attached is a crude patch that gets them working (though the changes done to configure.in, inside AC_CHECK_LIB, will produce ugly status string such as "checking for ov_open_callbacks in -lvorbisidec -logg", which is mostly a aesthetic concern)
Comment 1 Gabriel Jacobo 2012-09-20 16:03:36 UTC 
Created attachment 952 [details]
Ogg detection in static mode
Comment 2 Gabriel Jacobo 2012-09-21 13:39:04 UTC 
Created attachment 953 [details]
Call Music Finish Hook from Mix_HaltMusic

Adding an additional patch that fixes a separate issue, but as it's a small one I think it can live here anyway :)

The hook set up with Mix_HookMusicFinished is not being called when you issue a Mix_HaltMusic, though it should according to the documentation:

"int Mix_HaltMusic()
Halt playback of music. This interrupts music fader effects. Any callback set by Mix_HookMusicFinished will be called when the music stops."
Comment 3 Sam Lantinga 2012-09-26 20:36:14 UTC 
I applied your patch.  I agree it's kind of ugly, but I'm not sure what would be better.
http://hg.libsdl.org/SDL_mixer/rev/0aadc9b6daac

Please enter a separate bug for the other issue, as it needs to be evaluated by Ryan.

Thanks!
Comment 4 Rafał Mużyło 2012-10-22 12:49:12 UTC 
A bit late thought: isn't the fifth argument of AC_CHECK_LIB for this exact purpose ?