We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1581 - SDL_TouchQuit, SDL_DelTouch leaks memory
Summary: SDL_TouchQuit, SDL_DelTouch leaks memory
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: events (show other bugs)
Version: HG 2.0
Hardware: All All
: P1 minor
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.0
Depends on: 1580
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-26 07:30 UTC by Alexander Hirsch
Modified: 2013-07-14 17:52 UTC (History)
2 users (show)

See Also:

Attachments
this patch fixes both leaks (1.97 KB, application/octet-stream)
2012-08-26 07:30 UTC, Alexander Hirsch 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Hirsch 2012-08-26 07:30:46 UTC 
Created attachment 937 [details]
this patch fixes both leaks

SDL_TouchQuit calls SDL_DelTouch with an index instead of an id. This causes it not to free all SDL_Touch-es.
Further more, SDL_DelTouch does not free its fingers.

The attached patch implements SDL_DelTouchByIndex, SDL_DelFingerByIndex, fixes the loop in SDL_TouchQuit that would skip index 0 and adds one for SDL_DelTouch to call SDL_DelFingerByIndex on all of the SDL_Touch-es finger-indices.
Comment 1 Alexander Hirsch 2012-08-26 07:35:02 UTC 
Also, this bug does not really depend on Bug #1580, but without the fix it will crash (or invoke undefined behavior), which given the current incorrect implementation did not happen before.
Comment 2 Ryan C. Gordon 2013-07-12 18:52:29 UTC 
(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.0, Priority 1.

This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.
Comment 3 (disabled) Jørgen Tjernø 2013-07-14 17:52:12 UTC 
Fixed in http://hg.libsdl.org/SDL/rev/7833f01322b3 by Sam.