Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window/View is not correctly updated when device rotates #646

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Window/View is not correctly updated when device rotates #646

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.0
Reported for operating system, platform: All, iPhone/iPod touch

Comments on the original bug report:

On 2012-08-24 09:40:24 +0000, wrote:

$This is happening for status bar enabled (i.e. no fullscreen/no borderless) apps.$

When rotating the iOS device from the original position, the "didRotateFromInterfaceOrientation" member function is called (SDL_uikitviewcontroller.m), which updates all coordinate related variables in order to account for the rotation.

However, there is a bug concerning the frame update of the correspondent uiwindow/frame, which causes the ios screen to chop the first 20/40 pixels (retina/non-retina) of the sdl window.
This is happening because the following code is inserting a 20/40px margin on both uiwindow and data->view.

[uiwindow setFrame:frame];
[data->view setFrame:frame];

To fix it, one just apply null origin on frame, i.e. reset the frame margins (frame.origin.x/y) to zero.

[uiwindow setFrame:frame];
frame.origin = CGPointZero;
[data->view setFrame:frame];

On 2013-07-12 18:52:40 +0000, Ryan C. Gordon wrote:

(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.0, Priority 1.

This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.

On 2015-04-10 02:46:29 +0000, Ryan C. Gordon wrote:

This bug should be fixed by the changes made for Bug # 2798. Please reopen if that's not the case.

Thanks!

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant