We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1574 - updaterev.sh fails when path contains spaces
Summary: updaterev.sh fails when path contains spaces
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.0
Hardware: x86_64 Windows 7
: P2 blocker
Assignee: Andreas Schiffler
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-19 09:06 UTC by Andreas Schiffler
Modified: 2013-03-10 19:31 UTC (History)
0 users

See Also:

Attachments
Fixed updaterev.sh (1.00 KB, application/octet-stream)
2012-08-19 09:06 UTC, Andreas Schiffler 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schiffler 2012-08-19 09:06:33 UTC 
Created attachment 930 [details]
Fixed updaterev.sh

Building from 

 /cygdrive/c/Users/Andreas Schiffler/Desktop/Sources/SDL/build

on Windows using cygwin fails with

$ make
Warning, configure.in is out of date
#(cd .. && sh autogen.sh && sh configure)
/bin/sh ../build-scripts/updaterev.sh
mv: target `Schiffler/Desktop/Sources/SDL/build/include/SDL_revision.h' is not a directory
Makefile:113: recipe for target `update-revision' failed
make: *** [update-revision] Error 1

The script build-scripts/updaterev.sh needs to be updated to support paths with spaces in it by wrapping all occurrences of $header into "..".

Patch of fix attached.
Comment 1 Andreas Schiffler 2013-03-10 16:56:06 UTC 
Assigning to myself to apply the fix.
Comment 2 Andreas Schiffler 2013-03-10 19:31:53 UTC 
Patch applied and verified using this procedure
(cd SDL/build && make && make install)   
... works
(tar cvf SDL.tar && mkdir "Folder with Spaces" && cd "Folder with Spaces" && tar cvf ../SDL.tar && cd SDL/build && make clean && make && make install) 
... still works.