Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximize and restore events not generated #565

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Maximize and restore events not generated #565

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

SDLBugzilla commented Feb 10, 2021

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2012-03-08 16:36:48 +0000, Charles Huber wrote:

Created attachment 837
SDL_WINDOWEVENT logger

Running the attached program and maximizing/minimizing/restoring the window results in the following events:

Maximize: No event
Restore (from maximize): No event
Restore (from minimize): Event received
Minimize: Event received

Ubuntu 10.04, amd64.
GNOME2 with Metacity.

testver output:
Compiled with SDL 2.0 or newer
Compiled version: 2.0.0.6303 (hg-6303:6bb657898f55)
Linked version: 2.0.0.6303 (hg-6303:6bb657898f55)

On 2013-07-12 18:52:29 +0000, Ryan C. Gordon wrote:

(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.0, Priority 1.

This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.

On 2013-09-02 03:44:03 +0000, Henrique Santiago wrote:

I still have this bug on 2.0.0.

I've been looking at:

/src/video/x11/SDL_x11events.c

Line 509:
case ConfigureNotify:{


Maximized event is raised at ConfigureNotify case.
So i guess X11_GetNetWMState should be called from there to check if it's maximized or not, and then raise an SDL_WINDOWEVENT_MAXIMIZED if it's maximized.
I couldn't test it, but it seems that this can be the solution.

On 2013-09-10 19:43:52 +0000, Andrei Drexler wrote:

Created attachment 1327
Generate maximize/restore events with x11

Patch created against SDL2-2.0.0, generating maximize/restore events when running in x11.

On 2014-08-26 10:37:44 +0000, Alex Szpakowski wrote:

You should probably create the patch based on SDL-HG, rather than 1 year old code...

On 2014-08-26 20:06:55 +0000, Alex Szpakowski wrote:

Well that's embarrassing, I didn't see the date on your reply. :)

On 2014-08-27 11:25:59 +0000, Gergely Szász wrote:

Created attachment 1853
patch for hg snapshot

On 2015-02-02 06:22:09 +0000, Ryan C. Gordon wrote:

(In reply to Gergely Szász from comment # 6)

Created attachment 1853 [details]
patch for hg snapshot

I modified this slightly, and now this patch is https://hg.libsdl.org/SDL/rev/bb0b744fd1a6

Thanks, everyone!

--ryan.

On 2015-02-02 06:26:13 +0000, Ryan C. Gordon wrote:

*** Bug 2793 has been marked as a duplicate of this bug. ***

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant