Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian patch: Linking with -lm #25

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Debian patch: Linking with -lm #25

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: unspecified
Reported for operating system, platform: Linux, Other

Comments on the original bug report:

On 2012-01-27 12:15:21 +0000, wrote:

Hello,

We're going to ship this patch with the Debian packages, and I think you are maybe interested in incorporating it upstream, otherwise our package fails to build in some circumstances (e.g. with gold linker, or when using --as-needed flags; both of which are common in Debian and Ubuntu).

http://anonscm.debian.org/gitweb/?p=pkg-sdl/packages/sdl-ttf2.0.git;a=blob;f=debian/patches/link_libm_ftbfs_binutils-gold;h=c4340971fa55b6e0632c327e52b7ab6523a34716;hb=7fe2cd8851d9a68b855af29b708154c1d4327672

I don't think that you want to incorporate the patch as is, but well, you get the idea :-)

Regards.

On 2013-08-13 17:16:06 +0000, wrote:

Could you please try to take again a look at this patch?

Fixing it upstream should be straightforward and harmless and it would make easier for packagers to not have to carry the patch release after release.

On 2013-09-02 20:43:19 +0000, Julian Ospald wrote:

Gentoo is going to apply this too, however adding "-lm" to LDFLAGS is not the way to go.

--- a/Makefile.am
+++ b/Makefile.am
@@ -35,6 +35,7 @@
-release $(LT_RELEASE)
-version-info $(LT_CURRENT):$(LT_REVISION):$(LT_AGE)
endif
+libSDL2_ttf_la_LIBADD = @mathlib@

pkgconfigdir = $(libdir)/pkgconfig
pkgconfig_DATA = SDL2_ttf.pc

On 2013-09-05 13:52:37 +0000, Sam Lantinga wrote:

Fixed, thanks!
http://hg.libsdl.org/SDL_ttf/rev/e826b2504c66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant