Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11_KeyToUnicode function still there? #659

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

X11_KeyToUnicode function still there? #659

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 1.2.15
Reported for operating system, platform: Linux, Other

Comments on the original bug report:

On 2012-01-22 08:56:18 +0000, wrote:

Created attachment 793
x11_keytounicode.diff

Hello,

We had the following bug report at Debian:
http://bugs.debian.org/376560

Same one in Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/libsdl1.2/+bug/66217

We've been including a patch since then (attached) to actually export the symbol, since 2006. In the last release the function seems to be there, alive and kicking.

It's affecting other people too:
http://www.garagegames.com/community/forums/viewthread/52287

So maybe the issue should be fixed in some way or another? Having to export the symbol ourselves, modifying upstream API doesn't seem clean to me. On the other hand we don't want to disable to disable the patch and get a flow of complaints, just to have it enabled again.

Can you think of a clear solution?

1239 /*
1240 * This function is semi-official; it is not officially exported and should
1241 * not be considered part of the SDL API, but may be used by client code
1242 * that really needs it (including legacy code).
1243 * It is slow, though, and should be avoided if possible.
1244 *
1245 * Note that it isn't completely accurate either; in particular, multi-key
1246 * sequences (dead accents, compose key sequences) will not work since the
1247 * state has been irrevocably lost.
1248 */
1249 Uint16 X11_KeyToUnicode(SDLKey keysym, SDLMod modifiers)

On 2012-01-22 10:48:43 +0000, Sam Lantinga wrote:

At this point it's fine to leave it as an exported function, but not in the headers.
http://hg.libsdl.org/SDL/rev/900a0fae90ca

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant