We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1280 - Patch to split SDL_uikitviewcontroller in its own module
Summary: Patch to split SDL_uikitviewcontroller in its own module
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: iPhone/iPod touch iOS (All)
: P2 enhancement
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 13:19 UTC by Kees Bakker
Modified: 2011-08-24 20:34 UTC (History)
1 user (show)

See Also:

Attachments
The patch (16.69 KB, patch)
2011-08-18 13:21 UTC, Kees Bakker 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kees Bakker 2011-08-18 13:19:50 UTC 
The code for SDL_uikitviewcontroller is in src/video/uikit/SDL_uikitview.h and in src/video/uikit/SDL_uikitwindow.m. For new developers it is not immediately clear where the code for SDL_uikitviewcontroller is.

The attached ("hg export") patch creates src/video/uikit/SDL_uikitviewcontroller.h and src/video/uikit/SDL_uikitviewcontroller.m. The code itself wasn't changed, just copied to a new module. It makes the resulting uikit code a little cleaner.
Comment 1 Kees Bakker 2011-08-18 13:21:12 UTC 
Created attachment 675 [details]
The patch
Comment 2 Ryan C. Gordon 2011-08-22 12:07:39 UTC 
This is sitting in my sandbox repo now. I'll move this over to the main repo and resolve this bug soon.

Thanks!

--ryan.
Comment 3 Ryan C. Gordon 2011-08-24 20:34:45 UTC 
This is in the main repo now, thanks!

--ryan.