We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1246 - X11: Wrong initial size in tiling WM (+ solution?)
Summary: X11: Wrong initial size in tiling WM (+ solution?)
Status: RESOLVED WONTFIX
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 1.2.14
Hardware: x86 Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-14 01:01 UTC by Tony Lainson
Modified: 2012-06-21 02:43 UTC (History)
0 users

See Also:

Attachments
patch for X11_Wait(Un)Mapped (2.33 KB, patch)
2011-07-14 01:01 UTC, Tony Lainson 		Details | Diff
Same patch, but for SDL2 (2.31 KB, application/octet-stream)
2012-06-21 02:43 UTC, driedfruit 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Lainson 2011-07-14 01:01:14 UTC 
Created attachment 646 [details]
patch for X11_Wait(Un)Mapped

SDL 1.2 often fails to observe a resize event if it happens just as the window is being created.  No SDL_VIDEORESIZE event is sent to the application.  Any extra space remains black.

X11_WaitMapped() (in src/video/x11/SDL_x11modes.c) drops resize events that arrive before the window is mapped (StructureNotifyMask selects both MapNotify and ConfigureNotify events).  I think that might be a problem if the window manager resizes the window before mapping it.  Neither of the WMs I tried actually do that, but I've attached a patch anyway.

The real problem is in try_mitshm() (src/video/x11/SDL_x11image.c): XSync is called with the "discard" parameter set to True, which nukes everything in the event queue.  Is there a reason for that?  Would anything break if we changed it to False?

The XSync(blah, True) calls in other files look deliberate.  They make me uneasy, but I don't know what (if anything) should be done about them.  In any case, I haven't seen the resize bug since I changed True to False in try_mitshm().

I'm not at all familiar with SDL 1.3, but it looks like the only surviving problem is the XSync in the SHM code (which I haven't tried to trigger).  Nice work!
Comment 1 Sam Lantinga 2011-12-29 01:44:00 UTC 
I'm hesitant to change X11 behavior in SDL 1.2.  Thanks for the patch though!
Comment 2 driedfruit 2012-06-21 02:43:05 UTC 
Created attachment 883 [details]
Same patch, but for SDL2

Made against 6335:fbb84f5b985f