We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1233 - timidity: make testmidi to actually compile
Summary: timidity: make testmidi to actually compile
Status: RESOLVED ENDOFLIFE
Alias: None
Product: SDL_sound
Classification: Unclassified
Component: everything (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Ryan C. Gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 04:53 UTC by Ozkan Sezer
Modified: 2018-08-02 08:46 UTC (History)
0 users

See Also:

Attachments
timidity cleanups (19.21 KB, patch)
2011-06-16 04:54 UTC, Ozkan Sezer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2011-06-16 04:53:30 UTC 
Attached patch does the following:

- Add missing instrum_dls among the objects,
- Add a simple __Sound_SetError() wrapper to testmidi.c so that linkage succeeds
- Fix -ansi -pedantic warnings (extra semicolons at the end of a function, C++ style comments..)
- Fix two signedness mismatch in comparison (int vs. size_t) warning
- Fix a 'may be used uninitialized' warning in load_instrument_dls()
- Fix signedess mismatch warnings in pointer assignments in Parse_INFO_INS()

dls2.h still emits pedantic warnings like:
dls2.h:112: warning: ISO C does not allow extra ';' outside of a function
... but that might not be avoidable due to the empty-defining of DEFINE_GUID

These, I extracted from my copy of libtimidity that I use in uhexen2 (see at http://uhexen2.svn.sourceforge.net/viewvc/uhexen2/trunk/libs/timidity/).  The code may still be revised further for constification and C++ compiler compatibility.

Regards.
Comment 1 Ozkan Sezer 2011-06-16 04:54:35 UTC 
Created attachment 631 [details]
timidity cleanups
Comment 2 Ozkan Sezer 2018-08-02 08:46:34 UTC 
This is obsolete now, I think.