We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1232 - timidity, set master_drumset and master_tonebank to NULL upon exit
Summary: timidity, set master_drumset and master_tonebank to NULL upon exit
Status: RESOLVED FIXED
Alias: None
Product: SDL_sound
Classification: Unclassified
Component: everything (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Ryan C. Gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 11:38 UTC by Ozkan Sezer
Modified: 2011-06-15 13:15 UTC (History)
0 users

See Also:

Attachments
set master_drumset and master_tonebank to NULL after free()ing (514 bytes, patch)
2011-06-15 11:38 UTC, Ozkan Sezer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2011-06-15 11:38:39 UTC 
Created attachment 630 [details]
set master_drumset and master_tonebank to NULL after free()ing

Timidity_Exit() doesn't set master_drumset and master_tonebank to NULL which may lead to segfaults upon reinitialization. Attached tiny patch should handle that.
Comment 1 Ryan C. Gordon 2011-06-15 13:15:18 UTC 
This is now hg changeset e564b7029c29 for the development branch, and hg changeset 941847b13998 for the stable-1.0 branch.

Thanks!

--ryan.