We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1179 - IMG_jpg.c doesn't build with the new libjpeg
Summary: IMG_jpg.c doesn't build with the new libjpeg
Status: RESOLVED FIXED
Alias: None
Product: SDL_image
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86_64 Windows 7
: P2 API change
Assignee: Yury G. Kudryashov
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 07:24 UTC by fcoelho_9
Modified: 2011-12-31 09:36 UTC (History)
0 users

See Also:

Attachments
Diff for libjpeg 8 (383 bytes, application/octet-stream)
2011-04-07 07:24 UTC, fcoelho_9 		Details
Fix compilation on Linux (592 bytes, patch)
2011-09-25 17:09 UTC, Yury G. Kudryashov 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fcoelho_9 2011-04-07 07:24:58 UTC 
Created attachment 599 [details]
Diff for libjpeg 8

libjpeg 8 has a different naming scheme for booleans:

boolean -> JPEG_boolean
FALSE -> JPEG_FALSE
TRUE -> JPEG_TRUE

I'm building SDL_image with MinGW, attached is a small change I've made to IMG_jpg.c to be able to compile it.
Comment 1 Sam Lantinga 2011-04-07 08:01:37 UTC 
This is in, thanks!
http://hg.libsdl.org/SDL_image/rev/b1c1ec3a8d49
Comment 2 Yury G. Kudryashov 2011-09-25 17:09:34 UTC 
Created attachment 708 [details]
Fix compilation on Linux

TRUE was renamed to JPEG_TRUE by mingw port maintainers, not by upstream developers.

So instead of testing for version number one should test whether JPEG_TRUE is defined.

The attached patch is against the latest hg version.
Comment 3 Sam Lantinga 2011-12-31 09:36:49 UTC 
I like this patch, it's in, thanks!
http://hg.libsdl.org/SDL_image/rev/e0527402f476