We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 876

Summary: timidity: possible out of range
Product: SDL_mixer Reporter: Andrey <afletdinov>
Component: miscAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED WONTFIX QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: unspecified   
Hardware: Other   
OS: Linux   
Attachments: mid
mid

Description Andrey 2009-11-04 20:58:32 UTC 
valgrind out log:

==13703== Invalid write of size 2                                                                                                   
==13703==    at 0x407134B: load_instrument (instrum.c:807)                                                                          
==13703==    by 0x407209C: fill_bank (instrum.c:910)                                                                                
==13703==    by 0x4072402: load_missing_instruments (instrum.c:997)                                                                 
==13703==    by 0x407468F: Timidity_Start (playmidi.c:1744)                                                                         
==13703==    by 0x406D8B4: music_internal_play (music.c:709)                                                                        
==13703==    by 0x406D9AD: Mix_FadeInMusicPos (music.c:789)                                                                         
==13703==    by 0x406DA11: Mix_PlayMusic (music.c:800)                                                                              

==13703==  Address 0x4b1d2ac is 197,252 bytes inside a block of size 197,253 alloc'd                                                
==13703==    at 0x4025BDC: malloc (vg_replace_malloc.c:195)                                                                         
==13703==    by 0x406F66C: safe_malloc (common.c:218)                                                                               
==13703==    by 0x40711D9: load_instrument (instrum.c:689)                                                                          
==13703==    by 0x407209C: fill_bank (instrum.c:910)                                                                                
==13703==    by 0x4072402: load_missing_instruments (instrum.c:997)                                                                 
==13703==    by 0x407468F: Timidity_Start (playmidi.c:1744)                                                                         
==13703==    by 0x406D8B4: music_internal_play (music.c:709)                                                                        
==13703==    by 0x406D9AD: Mix_FadeInMusicPos (music.c:789)                                                                         
==13703==    by 0x406DA11: Mix_PlayMusic (music.c:800)                                                                              

mid file attachment
Comment 1 Sam Lantinga 2009-11-06 21:55:09 UTC 
Can you attach the offending MIDI file?

Thanks!
Comment 2 Andrey 2009-11-08 16:43:46 UTC 
Created attachment 445 [details]
mid

other files the same...
valgrind playmus canada.mid
...
==26824== Invalid write of size 2
==26824==    at 0x4B14474C: load_instrument (instrum.c:805)
==26824==    by 0x4B1451CD: fill_bank (instrum.c:907)
==26824==    by 0x4B145515: load_missing_instruments (instrum.c:995)
==26824==    by 0x4B147BFF: Timidity_Start (playmidi.c:1754)
==26824==    by 0x4B1295FF: music_internal_play (music.c:806)
==26824==    by 0x4B1296D1: Mix_FadeInMusicPos (music.c:881)
==26824==    by 0x4B12978A: Mix_FadeInMusic (music.c:888)
==26824==    by 0x804921D: main (in /usr/bin/playmus)
==26824==  Address 0x40D2F9E is 36,382 bytes inside a block of size 36,383 alloc'd
==26824==    at 0x40053C0: malloc (vg_replace_malloc.c:149)
==26824==    by 0x4B14281C: safe_malloc (common.c:211)
==26824==    by 0x4B144611: load_instrument (instrum.c:689)
==26824==    by 0x4B1451CD: fill_bank (instrum.c:907)
==26824==    by 0x4B145515: load_missing_instruments (instrum.c:995)
==26824==    by 0x4B147BFF: Timidity_Start (playmidi.c:1754)
==26824==    by 0x4B1295FF: music_internal_play (music.c:806)
==26824==    by 0x4B1296D1: Mix_FadeInMusicPos (music.c:881)
==26824==    by 0x4B12978A: Mix_FadeInMusic (music.c:888)
==26824==    by 0x804921D: main (in /usr/bin/playmus)
....
Comment 3 Andrey 2009-11-08 16:45:15 UTC 
Created attachment 446 [details]
mid

valgrind playmus babylon5.mid
...
==26842== Invalid write of size 2
==26842==    at 0x4B14474C: load_instrument (instrum.c:805)
==26842==    by 0x4B1451CD: fill_bank (instrum.c:907)
==26842==    by 0x4B145530: load_missing_instruments (instrum.c:997)
==26842==    by 0x4B147BFF: Timidity_Start (playmidi.c:1754)
==26842==    by 0x4B1295FF: music_internal_play (music.c:806)
==26842==    by 0x4B1296D1: Mix_FadeInMusicPos (music.c:881)
==26842==    by 0x4B12978A: Mix_FadeInMusic (music.c:888)
==26842==    by 0x804921D: main (in /usr/bin/playmus)
==26842==  Address 0x49F1820 is 13,120 bytes inside a block of size 13,121 alloc'd
==26842==    at 0x40053C0: malloc (vg_replace_malloc.c:149)
==26842==    by 0x4B14281C: safe_malloc (common.c:211)
==26842==    by 0x4B144611: load_instrument (instrum.c:689)
==26842==    by 0x4B1451CD: fill_bank (instrum.c:907)
==26842==    by 0x4B145530: load_missing_instruments (instrum.c:997)
==26842==    by 0x4B147BFF: Timidity_Start (playmidi.c:1754)
==26842==    by 0x4B1295FF: music_internal_play (music.c:806)
==26842==    by 0x4B1296D1: Mix_FadeInMusicPos (music.c:881)
==26842==    by 0x4B12978A: Mix_FadeInMusic (music.c:888)
==26842==    by 0x804921D: main (in /usr/bin/playmus)
...
Comment 4 Sam Lantinga 2009-11-08 19:27:02 UTC 
What instrument set are you using?

Thanks!
Comment 5 Andrey 2009-11-08 19:44:24 UTC 
Thank you!
I checked the instruments from: http://www.libsdl.org/projects/SDL_mixer/
Now works without errors.
Comment 6 Sam Lantinga 2009-11-08 20:15:45 UTC 
What instruments were causing problems?
Comment 7 Andrey 2009-11-08 20:18:51 UTC 
packet with error: fluid-soundfont-lite-patches-3.1-4.fc12.noarch