We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 71

Summary: Frame Buffer patches...
Product: SDL Reporter: Sam Lantinga <slouken>
Component: videoAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: don't know   
Hardware: x86   
OS: Linux   
Attachments: SDL-fb-open-lock.patch
SDL-fb-mousedrv-screensave.patch

Description Sam Lantinga 2006-01-24 01:01:21 UTC
Date: Tue, 4 Mar 2003 15:05:31 -0800
From: "Jim" <jim@fortunet.com>
Subject: [SDL] Frame Buffer patches...

 Okay I'm new at patch generation - so please tell me if there's a better
way
 I could have done this.

 Attached are two patch files generated with 'cvs diff -u'

 SDL-fb-open-lock.patch applies to SDL_fbvideo.c
    Modifies the open loop to check /dev/fb/0 found on devfs...

    Modifies the lock code to return failure if the current virtual terminal
 is not the one opened for frame buffer writing...
   Lock would hang forever if switched away (ctrl-alt-F1) ...

 SDL-fb-mousedrv-screensave.patch applies to SDL_fbevents.c
    Switches default mouse mode based on SDL_MOUSEDRV - currently only
 accepts PS2 - otherwise default is MS Mouse.

    When the screen is switched - exisiting code (wrapped in ifdef
 SAVE_SCREEN_COTENTS) would save the wrong bit of the screen....
     ( I run frame buffer 1600x1200, the size I requested was 800x600 - the
 save would save the top 800 lines (non biased) and restore them... Adding
 screen->offset fixed that )

    However, if that option is not set, then a call to SDL_UpdateRect (full
 screen) is made. (which may have had it's contents changed since the screen
 is not entirely locked because of lock-failure patch)

 Jim
Comment 1 Sam Lantinga 2006-01-24 01:04:40 UTC
Created attachment 29 [details]
SDL-fb-open-lock.patch
Comment 2 Sam Lantinga 2006-01-24 01:05:11 UTC
Created attachment 30 [details]
SDL-fb-mousedrv-screensave.patch
Comment 3 Sam Lantinga 2006-01-24 01:08:28 UTC
This might be related to bug #49
https://bugzilla.libsdl.org/show_bug.cgi?id=49
Comment 4 Ryan C. Gordon 2006-01-27 11:23:22 UTC
Setting Sam as "QA Contact" on all bugs (even resolved ones) so he'll definitely be in the loop to any further discussion here about SDL.

--ryan.

Comment 5 Sam Lantinga 2006-03-22 02:52:36 UTC
These patches are in CVS, thanks!