We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5332

Summary: [PATCH] WGI: Fix wrong level of indirection and implicit truncating cast.
Product: SDL Reporter: Joel Linn <jl>
Component: joystickAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: 2.0.13   
Hardware: x86_64   
OS: Windows 10   
Attachments: fix

Description Joel Linn 2020-10-30 22:41:28 UTC 
Created attachment 4489 [details]
fix

This fixes two types of MSVC compiler warnings.

- One parameter in the function signatures of two WGI event handlers had one level of indirection too much (and did not match Windows SDK headers). The indirection was cast away so it still worked.
- size_t was implicitly cast to UINT32 for a number of (constant) string lengths.
Comment 1 Sam Lantinga 2020-11-12 03:40:12 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/22cd290ba2cf