We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5265

Summary: [Patch] Redundant condition in KMSDRM_CreateCursor
Product: SDL Reporter: Mathieu Eyraud <meyraud705>
Component: videoAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: redwindwanderer
Version: 2.0.13   
Hardware: x86_64   
OS: Linux   
Attachments: fix redundant condition

Description Mathieu Eyraud 2020-08-19 10:43:42 UTC 
Created attachment 4443 [details]
fix redundant condition

'usable_cursor_w == 0' is checked twice on line 117 in KMSDRM_CreateCursor in ksmdrmmouse.c.
Comment 1 Manuel Alfayate Corchete 2020-09-13 19:43:08 UTC 
@meyraud705: Thanks a lot for this! I have been looking at this code for so long in the last week that I couldn't see details on it anymore... :D
Patch merged!
Comment 2 Manuel Alfayate Corchete 2020-09-13 19:43:52 UTC 
Suggested patch applied.