We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5170

Summary: Build fails when using Visual Studio 2017 with Windows 10 SDK 10.0.19041.0 in uwp
Product: SDL Reporter: JackBoosY <yuzaiyang>
Component: buildAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: major    
Priority: P2    
Version: 2.0.12   
Hardware: x86_64   
OS: Windows 10   
Attachments: Error info

Description JackBoosY 2020-06-01 06:41:48 UTC 
In src/video/winrt/SDL_winrtgamebar.cpp line 55:

    virtual HRESULT STDMETHODCALLTYPE add_VisibilityChanged( 
        __FIEventHandler_1_IInspectable *handler,
        Windows::Foundation::EventRegistrationToken *token) = 0;

The macro __FIEventHandler_1_IInspectable defined in windows.fondation.h(Windows10 SDK 10.0.17763.0) line 3576:
#define __FIVector_1_Windows__CFoundation__CPoint ABI::Windows::Foundation::Collections::__FIVector_1_Windows__CFoundation__CPoint_t

but no longer exists in Windows 10 SDK 10.0.19041.0.
After searching this macro in the sdk include path, I found that it was defined in many header files. But it should be replaced in windows.system.h .

Can anyone confirm this?

Thanks.

Related PR: https://github.com/microsoft/vcpkg/pull/11647
Comment 1 JackBoosY 2020-06-01 06:44:02 UTC 
Created attachment 4364 [details]
Error info
Comment 2 Sam Lantinga 2020-06-10 16:39:21 UTC 
Yep, that looks good to me. Thanks!
https://hg.libsdl.org/SDL/rev/7c2f418f701b