We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5103

Summary: Port fcitx support to both fcitx 4 & 5
Product: SDL Reporter: wengxt
Component: *don't know*Assignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: sdl
Version: HG 2.1   
Hardware: x86_64   
OS: Linux   
Attachments: Patch to support fcitx 5
Update the patch to support build with cmake

Description wengxt 2020-04-22 08:36:49 UTC
Created attachment 4318 [details]
Patch to support fcitx 5

Due to the new major fcitx version is coming close, the existing code need to be ported to use new Fcitx dbus interface.

The new dbus interface is supported by both fcitx 4 and 5, and has a good side effect, which is that it will work with flatpak for free. Also the patch remove the dependency on fcitx header. Instead, it just hardcodes a few enum value in the code so need to handle the different header for fcitx4 or 5.
Comment 1 Jerry Xiao 2020-05-10 03:25:56 UTC
(In reply to wengxt from comment #0)
> Created attachment 4318 [details]
> Patch to support fcitx 5
> 
> Due to the new major fcitx version is coming close, the existing code need
> to be ported to use new Fcitx dbus interface.
> 
> The new dbus interface is supported by both fcitx 4 and 5, and has a good
> side effect, which is that it will work with flatpak for free. Also the
> patch remove the dependency on fcitx header. Instead, it just hardcodes a
> few enum value in the code so need to handle the different header for fcitx4
> or 5.

Nice job!
Comment 2 wengxt 2020-05-11 04:47:37 UTC
Created attachment 4337 [details]
Update the patch to support build with cmake
Comment 3 Sam Lantinga 2020-05-11 21:31:29 UTC
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/a73b49512ba2