| Summary: | CMake builds on Windows broken by sensor support | ||
|---|---|---|---|
| Product: | SDL | Reporter: | DominikD <conayr> |
| Component: | *don't know* | Assignee: | Ryan C. Gordon <icculus> |
| Status: | ASSIGNED --- | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | HG 2.0 | ||
| Hardware: | x86_64 | ||
| OS: | Windows 10 | ||
| Attachments: | sensor support in SDL_config.h.cmake + hack in SDL_windowssensor.c | ||
Thanks, your patch to SDL_config.h.cmake is in: https://hg.libsdl.org/SDL/rev/0aea93477d09 I'll look more closely at why my Sensors.h doesn't define the angular velocity properties. |
Created attachment 4303 [details] sensor support in SDL_config.h.cmake + hack in SDL_windowssensor.c CMakes on HG tip are currently broken (at least on Windows). There are three problems I've noticed: 1. Sensor support missing in `SDL_config.h.cmake`. 2. `SENSOR_DATA_TYPE_ANGULAR_VELOCITY_*_DEGREES_PER_SECOND` symbols duplication. 3. If SDL_SENSOR is disabled, dynapi build fails on sensor-related APIs. The first one is easily fixable in the patch attached. The second one would require `DEFINE_PROPERTYKEY` lines to be removed (I get them from `#include <Sensors.h>`) but I assume these were added for a reason. Ugly hack in the patch attached. The last one may be something wrong I'm doing. Given that sensor support seems to be very much WIP it's likely that tip will change before maintainers attend to this report. But I hope it's at least a little bit useful (don't know if any of you guys uses Windows as the default platform).